Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move global random number generator to randRes field #5819

Merged
merged 5 commits into from
Sep 16, 2024

Commits on Sep 13, 2024

  1. Move global RNG to randRes field

    Instead of using a global random number generator for all `randRes`,
    have each value use its own. This removes the need for locking and
    managing concurrent safe access to the global. Also, the field, given
    the `Reservoir` type is not concurrent safe and the metric pipeline
    guards this, does not need a `sync.Mutex` to guard it.
    MrAlias committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2d62423 View commit details
    Browse the repository at this point in the history
  2. Add TestFixedSizeExemplarConcurrentSafe

    This verifies this as a fix to open-telemetry#5814.
    MrAlias committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    02d1be2 View commit details
    Browse the repository at this point in the history
  3. Add changelog entry

    MrAlias committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    31167bf View commit details
    Browse the repository at this point in the history
  4. Fix lint

    MrAlias committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    289da3a View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    9f4e8cd View commit details
    Browse the repository at this point in the history