Use StateLocker in MinMaxSumCount #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
MrAlias
reviewed
Mar 12, 2020
MrAlias
reviewed
Mar 12, 2020
paivagustavo
approved these changes
Mar 12, 2020
jmacd
approved these changes
Mar 12, 2020
rghetia
reviewed
Mar 12, 2020
rghetia
approved these changes
Mar 12, 2020
MikeGoldsmith
pushed a commit
to MikeGoldsmith/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
* Add MinMaxSumCount stress test * Reimplement MinMaxSumCount using StateLocker * Address PR comments * Round open-telemetry#2 of PR comments Co-authored-by: Rahul Patel <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #535
Closes #437
Reimplement MinMaxSumCount using StateLocker to ensure a consistent set of values for the aggregator's outputs.
Added a stress test that fails under the earlier MinMaxSumCount implementation, but succeeds with the new StateLocker-based implementation.