Update Samplers to conform to Spec #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sampler is now an interface rather than a function type * SamplingParameters include the span Kind, Attributes, and Links * SamplingResult includes a SamplingDecision with three possible values, as well as Attributes
Aneurysm9
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
jmacd
reviewed
Mar 9, 2020
krnowak
suggested changes
Mar 9, 2020
krnowak
approved these changes
Mar 10, 2020
jmacd
approved these changes
Mar 10, 2020
MikeGoldsmith
pushed a commit
to MikeGoldsmith/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
* Refactor SDK Sampler API to conform to Spec * Sampler is now an interface rather than a function type * SamplingParameters include the span Kind, Attributes, and Links * SamplingResult includes a SamplingDecision with three possible values, as well as Attributes * Add attributes retruned from a Sampler to the span * Add SpanKind, Attributes, and Links to API Sampler.ShouldSample() parameters * Drop "Get" from sdk Sampler.GetDescription to match api Sampler * Make spanID parameter in API Sampler interface a core.SpanID * Fix types and printf format per PR feedback from krnowak * Ensure unit test error messages reflect new reality Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519.