Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status message parameter #524

Merged
merged 5 commits into from
Mar 7, 2020
Merged

Add status message parameter #524

merged 5 commits into from
Mar 7, 2020

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Mar 6, 2020

Resolves #491

@jmacd
Copy link
Contributor Author

jmacd commented Mar 6, 2020

Note that I removed several calls to SetStatus(codes.OK) because that is the default in the spec:

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-tracing.md#set-status

rghetia
rghetia approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd
Copy link
Contributor Author

jmacd commented Mar 7, 2020

Misc: There were SetStatus changes for Stackdriver lost in bf1bab5 that will come up after the next release.

@jmacd jmacd merged commit 3bf3927 into open-telemetry:master Mar 7, 2020
@jmacd jmacd deleted the jmacd/add_status_message branch March 7, 2020 18:39
MikeGoldsmith pushed a commit to MikeGoldsmith/opentelemetry-go that referenced this pull request Mar 13, 2020
@jmacd @MikeGoldsmith
Add status message parameter (open-telemetry#524)
80797a5 
* Add status message parameter

* Cleanups around use of codes.OK

* Update for status message
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@krnowak krnowak Awaiting requested review from krnowak

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@MrAlias MrAlias Awaiting requested review from MrAlias

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

SetStatus does not accept a message string
3 participants
@jmacd @rghetia @pellared