Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip test-386 for Mac OS 10.15.x (Catalina and upwards). #521

Merged
merged 3 commits into from
Mar 5, 2020
Merged

skip test-386 for Mac OS 10.15.x (Catalina and upwards). #521

merged 3 commits into from
Mar 5, 2020

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Mar 5, 2020

fixes #520

lizthegrey
lizthegrey approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@lizthegrey lizthegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe spare all the extra newlines, but otherwise LGTM

@rghetia rghetia merged commit 20ecc38 into open-telemetry:master Mar 5, 2020
MikeGoldsmith pushed a commit to MikeGoldsmith/opentelemetry-go that referenced this pull request Mar 13, 2020
@rghetia @MikeGoldsmith
skip test-386 for Mac OS 10.15.x (Catalina and upwards). (open-teleme…
b7149d0 
…try#521)

* skip test-386 for Mac OS 10.15.x (Catalina and upwards).

fixes open-telemetry#520

* fix indentation

* remove extra newlines.
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@lizthegrey lizthegrey lizthegrey approved these changes

@krnowak krnowak krnowak approved these changes

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

test-386 fails on Mac OS 10.15.x (Catalina)
5 participants
@rghetia @krnowak @lizthegrey @MrAlias @pellared