[chore] Add godoc target #5176
[chore] Add godoc target #5176
Conversation
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
=====================================
Coverage 83.8% 83.8%
=====================================
Files 254 254
Lines 16532 16532
=====================================
+ Hits 13864 13866 +2
+ Misses 2375 2373 -2
Partials 293 293 |
|
|
||
| .PHONY: godoc | ||
| godoc: | ||
| go install golang.org/x/pkgsite/cmd/pkgsite@latest |
There was a problem hiding this comment.
This should be included in our tools instead of installed each invocation of godoc
There was a problem hiding this comment.
See description why I decided this way.
There was a problem hiding this comment.
There are commit releases. We should track those. Dependabot can handle updates for that as well.
There was a problem hiding this comment.
Dependabot can handle updates for that as well.
Are you sure? The related issue and my experience says otherwise
There was a problem hiding this comment.
If not, I do not support adding this. It deviates from our tooling pattern and, as you pointed out, is not a stable set of tooling that we can guarantee versioning for.
There was a problem hiding this comment.
I am totally fine with it. Closing the PR.
| @@ -310,3 +310,8 @@ lint-markdown: | |||
| .PHONY: verify-readmes | |||
| verify-readmes: | |||
| ./verify_readmes.sh | |||
|
|
|||
| .PHONY: godoc | |||
| godoc: | |||
There was a problem hiding this comment.
| godoc: | |
| pkgsite: |
I was considering adding
pkgsitetointernal/tools/go.mod. However, it has no tagged version so updating would be quite painful (no dependabot updates). Related issue: dependabot/dependabot-core#2028