Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global log package #5085

Merged
merged 19 commits into from
Mar 19, 2024
Merged

Add global log package #5085

merged 19 commits into from
Mar 19, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 18, 2024

Resolve #5084

Building out logging bridges will require some global logging package to reference similar to what exists when the log package becomes stable. Similar to what we did for the metric signal, add a log/global package that implements a global logging provider.

@MrAlias MrAlias added pkg:API Related to an API package area:logs Part of OpenTelemetry logs labels Mar 18, 2024
@MrAlias MrAlias added this to the v1.25.0 milestone Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.6%. Comparing base (12c5651) to head (8242eca).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5085   +/-   ##
=====================================
  Coverage   83.5%   83.6%           
=====================================
  Files        244     247    +3     
  Lines      16029   16085   +56     
=====================================
+ Hits       13399   13453   +54     
- Misses      2342    2344    +2     
  Partials     288     288           
Files Coverage Δ
log/internal/global/log.go 100.0% <100.0%> (ø)
log/internal/global/state.go 100.0% <100.0%> (ø)
log/global/log.go 66.6% <66.6%> (ø)

@MrAlias MrAlias merged commit 335f4de into open-telemetry:main Mar 19, 2024
27 checks passed
@MrAlias MrAlias deleted the log-global branch March 19, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs pkg:API Related to an API package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add temporary global implementation for logging
3 participants