-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithEndpointURL option to OTLP over HTTP exporters #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
January 2, 2024 13:39
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4808 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 226 226
Lines 18421 18481 +60
=====================================
+ Hits 15164 15224 +60
Misses 2971 2971
Partials 286 286
|
pellared
previously requested changes
Jan 2, 2024
exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/options.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Pająk <[email protected]>
pellared
reviewed
Jan 3, 2024
pellared
approved these changes
Jan 3, 2024
This comment was marked as resolved.
This comment was marked as resolved.
pellared
approved these changes
Jan 3, 2024
hanyuancheung
approved these changes
Jan 10, 2024
lizthegrey
approved these changes
Jan 12, 2024
pellared
changed the title
Introduce WithEndpointURL option to OTLP exporters
Add WithEndpointURL option to OTLP over HTTP exporters
Jan 19, 2024
m-posluszny
pushed a commit
to m-posluszny/opentelemetry-go
that referenced
this pull request
Jan 19, 2024
…y#4808) Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3730.