Use url.PathUnescape when parsing OTLP headers and resource attributes env vars

[mikeblum]

…headers and resource attributes env vars (#4698).

A note: we might want to consolidate the table test data across grpc and html as there is a bit of drift / inconsistency in the test cases for each protocol?

EDIT: 😅 I modified the generated files initially:

#4699 (comment)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mikeblum / name: Michael Blum (7011c66)

[mikeblum]

prior art: #4667

[codecov]

Codecov Report

Merging #4699 (7011c66) into main (0c5ebd5) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4699     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        225     225             
  Lines      18087   18087             
=======================================
- Hits       14798   14796      -2     
- Misses      2992    2994      +2     
  Partials     297     297             

Files	Coverage Δ
...ric/otlpmetricgrpc/internal/envconfig/envconfig.go	86.4% <100.0%> (ø)
...ric/otlpmetrichttp/internal/envconfig/envconfig.go	86.4% <100.0%> (ø)
...race/otlptracegrpc/internal/envconfig/envconfig.go	86.4% <100.0%> (ø)
...race/otlptracehttp/internal/envconfig/envconfig.go	86.4% <100.0%> (ø)
sdk/resource/env.go	94.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

[Aneurysm9]

Please run make precommit to ensure formatting is correctly applied.

[pellared]

Can you please add some tests cases that would fail for url.QueryUnescape, but are now passing thanks to url.PathUnescape?

EDIT: For OTLP it would be adding test cases to TestStringToHeader, for resource it should be a new test in sdk/resource/env_test.go

[mikeblum]

Ah I see what happened; I had modified the generated table tests here vs the src in internal/shared/otlp/envconfig/envconfig_test.go.tmpl. Looking at the RFC 3986 vs net/url.PathUnescape it seems like the only diff are how + are handled?

Anyways this should cut down on the duplication i had originally.

[mikeblum]

Checked CONTRIBUTING.md but I wasn't sure if squashing was enabled or not for PRs so I did it manually. Thanks for pushing up your suggestions!

[pellared]

@mikeblum Thank you for your contribution 👍