-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus exporter: do not append _total if the metric already ends in _total #4373
Conversation
ca06bbe
to
fe54953
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4373 +/- ##
=======================================
- Coverage 83.5% 83.4% -0.2%
=======================================
Files 229 184 -45
Lines 18647 14389 -4258
=======================================
- Hits 15578 12004 -3574
+ Misses 2751 2157 -594
+ Partials 318 228 -90
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the changelog needs to be refined 😉
@dashpole this looks ready to merge. Can you resolve the conflicts and sync with main? |
b833918
to
12554e4
Compare
@MrAlias rebased |
Fixes #4371
It accomplishes this by trimming _total suffix from counter metrics if we are going to re-add the suffix later.