-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move otlpmetrics Client
to an internal package.
#3486
Merged
MrAlias
merged 5 commits into
open-telemetry:main
from
MadVikingGod:mvg/otlp-clientless
Nov 23, 2022
Merged
Move otlpmetrics Client
to an internal package.
#3486
MrAlias
merged 5 commits into
open-telemetry:main
from
MadVikingGod:mvg/otlp-clientless
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
November 21, 2022 15:46
MrAlias
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when minor issues resolved.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3486 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 165 165
Lines 11614 11614
=====================================
Hits 9046 9046
Misses 2372 2372
Partials 196 196
|
MrAlias
added
area:metrics
Part of OpenTelemetry Metrics
pkg:exporter:otlp
Related to the OTLP exporter package
labels
Nov 21, 2022
Co-authored-by: Tyler Yahn <[email protected]>
jmacd
approved these changes
Nov 21, 2022
MrAlias
reviewed
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3455
This was discussed in the SIG meeting. We want to move the
exporters/otlp/otlpmetric.Client
interface into an internal package. This allows for the current common logic to be shared between otlpmetrichttp and otlpmetricgrpc, but allows us to expose this in the future if needed.Users of
otlpmetric.New()
will need to use theotlpmetric[http|grpc].New()
directly.