Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move otlpmetrics Client to an internal package. #3486

Merged
merged 5 commits into from
Nov 23, 2022

Conversation

MadVikingGod
Copy link
Contributor

Resolves #3455

This was discussed in the SIG meeting. We want to move the exporters/otlp/otlpmetric.Client interface into an internal package. This allows for the current common logic to be shared between otlpmetrichttp and otlpmetricgrpc, but allows us to expose this in the future if needed.

Users of otlpmetric.New() will need to use the otlpmetric[http|grpc].New() directly.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when minor issues resolved.

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3486 (470b506) into main (c4333a9) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3486   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        165     165           
  Lines      11614   11614           
=====================================
  Hits        9046    9046           
  Misses      2372    2372           
  Partials     196     196           
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/internal/exporter.go 67.2% <ø> (ø)
exporters/otlp/otlpmetric/internal/otest/client.go 97.1% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 85.7% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.6% <100.0%> (ø)

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Nov 21, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Nov 21, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit e36a361 into open-telemetry:main Nov 23, 2022
@MadVikingGod MadVikingGod deleted the mvg/otlp-clientless branch February 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Do NOT expose generated protos in metrics exporter
3 participants