-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle duplicate Aggregators and log instrument conflicts #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Sep 30, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3251 +/- ##
=======================================
+ Coverage 77.5% 77.6% +0.1%
=======================================
Files 160 161 +1
Lines 11203 11280 +77
=======================================
+ Hits 8690 8763 +73
- Misses 2313 2317 +4
Partials 200 200
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
September 30, 2022 21:16
This was referenced Sep 30, 2022
MadVikingGod
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor nits.
Aneurysm9
reviewed
Oct 7, 2022
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Aneurysm9
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Part of OpenTelemetry Metrics
bug
Something isn't working
pkg:SDK
Related to an SDK package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Meter
is asked to create an instrument that already exists...Aggregator
s.Aggregator
s but log the collision as a warning.This PR updates the metric SDK to achieve these things. It does this with the following.
cache
type described in Unify metric SDK caching #3245instrumentCache
that wraps twocache
s. One to cache instrument aggregations and ensure they are unique. The other to cache resolved viewinstrumentID
s so any conflicting creations are logged (something recommended by the spec).Meter
level. This ensures that no duplicate instruments are issued per instrumentation scope. It also ensures that instrument conflicts are appropriately logged as such per instrumentation scope.map
s.Part of #3245
Fix #3240
Fix #3229