Change SpanKind type an integer type #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
bogdandrutu,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
This comment has been minimized.
This comment has been minimized.
jmacd
changed the title
|
Earlier, I had requested @paivagustavo use a string type to represent span kinds, recognizing that the spec was strict about having exactly five legal values. I failed to understand the true intention, and so I am reverting the change I asked for. |
rghetia
approved these changes
Nov 4, 2019
This comment has been minimized.
This comment has been minimized.
paivagustavo
reviewed
Nov 4, 2019
There was a problem hiding this comment.
@paivagustavo Sorry I led you astray. I hadn't understood the true intention behind SpanKind but did eventually after this spec discussion:
No worries :)
I've added some questions about these changes.
added 3 commits
November 4, 2019 14:29
paivagustavo
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paivagustavo Sorry I led you astray. I hadn't understood the true intention behind
SpanKindbut did eventually after this spec discussion:open-telemetry/opentelemetry-specification#337