Use subtests in the trace package #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
As this only changes tests, it shouldn't need a changelog entry. |
dmathieu
commented
Feb 9, 2022
| @@ -26,74 +26,91 @@ import ( | |||
| // Taken from the W3C tests: | |||
| // https://github.com/w3c/trace-context/blob/dcd3ad9b7d6ac36f70ff3739874b73c11b0302a1/test/test_data.json | |||
| var testcases = []struct { | |||
| name string | |||
There was a problem hiding this comment.
Technically, we could use in as the name of the subtest here. I've added an explicit name though, as I believe it makes it clearer what the case's goal is.
pellared
approved these changes
Feb 9, 2022
dashpole
approved these changes
Feb 9, 2022
MrAlias
approved these changes
Feb 9, 2022
Aneurysm9
approved these changes
Feb 9, 2022
MadVikingGod
approved these changes
Feb 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
- Coverage 76.2% 76.1% -0.1%
=======================================
Files 173 173
Lines 12238 12238
=======================================
- Hits 9328 9322 -6
- Misses 2667 2673 +6
Partials 243 243
|
|
This is a test-only change with several approvals already; merging prior to 24h. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking at tests within the trace package, I noticed they use range test cases, but without sub tests, making it harder to run a single test.