Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up docs and other othttp cleanups #218

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Fix up docs and other othttp cleanups #218

merged 2 commits into from
Oct 17, 2019

Conversation

freeformz
Copy link
Contributor

Closes #211

This includes a few cleanups that are more obvious to me now as well.

rghetia
rghetia reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit. otherwise LGTM.

plugin/othttp/handler.go Outdated Show resolved Hide resolved
dmathieu
dmathieu reviewed Oct 17, 2019
View reviewed changes
plugin/othttp/doc.go Outdated Show resolved Hide resolved
jmacd
jmacd approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These var declarations can become const now with #217

@freeformz freeformz force-pushed the ffz/othttp branch 3 times, most recently from 0fdda0c to c4aed58 Compare October 17, 2019 17:22
@freeformz
Copy link
Contributor Author

@jmacd Yep. Done.

@rghetia rghetia merged commit 4172bdf into open-telemetry:master Oct 17, 2019
@rghetia rghetia mentioned this pull request Oct 17, 2019
Merged
@MrAlias MrAlias mentioned this pull request Apr 7, 2022
Closed
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu left review comments

@rghetia rghetia rghetia approved these changes

@jmacd jmacd jmacd approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@pjanotti pjanotti Awaiting requested review from pjanotti

@sjkaris sjkaris Awaiting requested review from sjkaris

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Better documentation for othttp
5 participants
@freeformz @dmathieu @jmacd @rghetia @pellared