-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on metrics packages #1988
Conversation
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1988 +/- ##
=====================================
Coverage 77.2% 77.2%
=====================================
Files 161 162 +1
Lines 8495 8495
=====================================
Hits 6563 6563
- Misses 1679 1680 +1
+ Partials 253 252 -1
|
Signed-off-by: Anthony J Mirabella <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving otel/oteltest
to otel/metric/oteltest
means that package name doesn't match the test package naming pattern we try to implement (i.e. ${PACKAGE_NAME}test
). Can we rename it to metrictest
?
Signed-off-by: Anthony J Mirabella <[email protected]>
Signed-off-by: Anthony J Mirabella <[email protected]>
…o fix/metrics_b_gon
…o fix/metrics_b_gon
Creates a new
internal/metric
module and moves metric-related internals there. The metric-related test helpers fromoteltest
have moved tometric/oteltest
. This should eliminate all dependence on the metrics API module from modules that will be declared stable atv1.0.0
.