-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor exporter creation functions #1985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:example
Related to an example
release:1.0.0-rc.1
pkg:exporter:prometheus
Related to the Prometheus exporter package
pkg:exporter:otlp
Related to the OTLP exporter package
pkg:exporter:stdout
Related to the stdout exporter package
pkg:exporter:jaeger
Related to the Jaeger exporter package
pkg:exporter:zipkin
Related to the Zipkin exporter package
labels
Jun 9, 2021
MrAlias
requested review from
evantorrie,
jmacd,
MadVikingGod,
paivagustavo and
XSAM
as code owners
June 9, 2021 16:45
MrAlias
commented
Jun 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #1985 +/- ##
=====================================
Coverage 77.1% 77.2%
=====================================
Files 161 161
Lines 8593 8495 -98
=====================================
- Hits 6631 6563 -68
+ Misses 1701 1679 -22
+ Partials 261 253 -8
|
Aneurysm9
reviewed
Jun 9, 2021
paivagustavo
approved these changes
Jun 9, 2021
Aneurysm9
approved these changes
Jun 9, 2021
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:example
Related to an example
pkg:exporter:jaeger
Related to the Jaeger exporter package
pkg:exporter:otlp
Related to the OTLP exporter package
pkg:exporter:prometheus
Related to the Prometheus exporter package
pkg:exporter:stdout
Related to the stdout exporter package
pkg:exporter:zipkin
Related to the Zipkin exporter package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallNewPipeline
/NewExportPipeline
functions from exporters. This resolves Exporter convenience functions do not set a service name by default #1979NewExporter
functions to be justNew
. This removes the redundancy of the name and follows common Go naming patterns