-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Tracer method from the Span API #1900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
Related to an API package
area:trace
Part of OpenTelemetry tracing
release:1.0.0-rc.1
labels
May 11, 2021
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
May 11, 2021 16:59
MrAlias
commented
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 139 139
Lines 7418 7414 -4
=======================================
- Hits 5894 5889 -5
- Misses 1278 1279 +1
Partials 246 246
|
dashpole
approved these changes
May 11, 2021
Aneurysm9
approved these changes
May 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same tracer that created a span introduces the error where an instrumentation library's
Tracer
is used by other code instead of their own. There is no requirement from the OpenTelemetry specification to include this method in the Span API and it looks like it was borrowed from OpenTracing, where the instrumentation library concept does not exist.This removes the
Tracer
method from theSpan
interface in thetrace
package and all methods from implementations.Resolve #1892
Resolve #1887