Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Tracer method from the Span API #1900

Merged
merged 7 commits into from
May 12, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 11, 2021

Using the same tracer that created a span introduces the error where an instrumentation library's Tracer is used by other code instead of their own. There is no requirement from the OpenTelemetry specification to include this method in the Span API and it looks like it was borrowed from OpenTracing, where the instrumentation library concept does not exist.

This removes the Tracer method from the Span interface in the trace package and all methods from implementations.

Resolve #1892
Resolve #1887

@MrAlias MrAlias added pkg:API Related to an API package area:trace Part of OpenTelemetry tracing release:1.0.0-rc.1 labels May 11, 2021
@MrAlias MrAlias added this to the RC1 milestone May 11, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1900 (7c0059d) into main (ae85fab) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1900     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        139     139             
  Lines       7418    7414      -4     
=======================================
- Hits        5894    5889      -5     
- Misses      1278    1279      +1     
  Partials     246     246             
Impacted Files Coverage Δ
oteltest/harness.go 84.2% <ø> (-0.1%) ⬇️
oteltest/span.go 100.0% <ø> (ø)
sdk/trace/span.go 88.8% <ø> (-0.1%) ⬇️
trace/noop.go 53.8% <ø> (-3.3%) ⬇️
trace/trace.go 86.7% <ø> (ø)
bridge/opentracing/internal/mock.go 72.7% <0.0%> (-1.0%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit b6d5442 into open-telemetry:main May 12, 2021
@MrAlias MrAlias deleted the rm-span-tracer branch May 12, 2021 15:24
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior for default unimplemented API span Tracer method
3 participants