Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configs #1882

Merged
merged 14 commits into from
May 14, 2021
Merged

Refactor configs #1882

merged 14 commits into from
May 14, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented May 5, 2021

Partially solves: #536

Why

Follow standards affecting exported API before RC.

What

Unify the configuration and options API in accordance to: https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#configuration

Refactor option and config types in:

  • sdk/trace/provider.go
  • sdk/trace/sampling.go
  • sdk/metric/controller/basic/config.go
  • sdk/metric/aggregator/histogram/histogram.go
  • sdk/metric/processor/basic/config.go
  • sdk/resource/config.go
  • trace/config.go POSTPONED - requires major refactoring as New*Config functions are exported and used in other packages
  • metric/config.go POSTPONED - requires major refactoring
  • oteltest/config.go
  • exporters/otlp/options.go
  • exporters/otlp/protocoldriver.go
  • exporters/otlp/otlpgrpc/options.go
  • exporters/otlp/otlphttp/options.go
  • exporters/stdout/config.go
  • exporters/trace/jaeger/uploader.go
  • exporters/trace/zipkin/zipkin.go

"Codecov/patch" fails, because of the refactoring. The test coverage from the logical perspective remains the same.

Next PR(s)

Try tackling trace/config.go and metric/config.go.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1882 (d6ef32c) into main (6324ada) will increase coverage by 0.0%.
The diff coverage is 70.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1882   +/-   ##
=====================================
  Coverage   79.4%   79.5%           
=====================================
  Files        139     139           
  Lines       7452    7463   +11     
=====================================
+ Hits        5921    5937   +16     
+ Misses      1283    1278    -5     
  Partials     248     248           
Impacted Files Coverage Δ
exporters/stdout/metric.go 76.3% <ø> (ø)
exporters/stdout/trace.go 69.5% <ø> (ø)
sdk/resource/config.go 100.0% <ø> (+9.0%) ⬆️
exporters/otlp/otlpgrpc/options.go 46.3% <44.8%> (+1.3%) ⬆️
exporters/otlp/otlphttp/options.go 57.6% <56.0%> (+1.6%) ⬆️
exporters/stdout/config.go 70.0% <62.5%> (+16.1%) ⬆️
exporters/trace/jaeger/uploader.go 50.0% <62.5%> (-0.7%) ⬇️
exporters/trace/zipkin/zipkin.go 73.0% <83.3%> (+0.1%) ⬆️
exporters/otlp/options.go 100.0% <100.0%> (ø)
exporters/otlp/otlp.go 83.9% <100.0%> (ø)
... and 13 more

@pellared pellared force-pushed the refactor-configs branch 2 times, most recently from 69a8e2e to 969e907 Compare May 13, 2021 09:41
@pellared pellared marked this pull request as ready for review May 13, 2021 12:54
@pellared pellared changed the title [WIP] Refactor configs Refactor configs May 13, 2021
@pellared pellared closed this May 13, 2021
@pellared pellared reopened this May 13, 2021
sdk/trace/provider.go Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit d23cc61 into open-telemetry:main May 14, 2021
@pellared pellared deleted the refactor-configs branch May 14, 2021 20:37
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants