-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor configs #1882
Merged
Merged
Refactor configs #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1882 +/- ##
=====================================
Coverage 79.4% 79.5%
=====================================
Files 139 139
Lines 7452 7463 +11
=====================================
+ Hits 5921 5937 +16
+ Misses 1283 1278 -5
Partials 248 248
|
pellared
commented
May 5, 2021
pellared
force-pushed
the
refactor-configs
branch
2 times, most recently
from
May 13, 2021 09:41
69a8e2e
to
969e907
Compare
pellared
requested review from
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
May 13, 2021 12:54
Aneurysm9
reviewed
May 13, 2021
pellared
force-pushed
the
refactor-configs
branch
from
May 13, 2021 16:47
91eb40b
to
ec655ef
Compare
Aneurysm9
approved these changes
May 13, 2021
pellared
force-pushed
the
refactor-configs
branch
from
May 13, 2021 18:02
ec655ef
to
6908c0a
Compare
dashpole
approved these changes
May 13, 2021
MrAlias
approved these changes
May 13, 2021
pellared
force-pushed
the
refactor-configs
branch
from
May 14, 2021 10:16
6908c0a
to
d6ef32c
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves: #536
Why
Follow standards affecting exported API before RC.
What
Unify the configuration and options API in accordance to: https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#configuration
Refactor option and config types in:
sdk/trace/provider.go
sdk/trace/sampling.go
sdk/metric/controller/basic/config.go
sdk/metric/aggregator/histogram/histogram.go
sdk/metric/processor/basic/config.go
sdk/resource/config.go
trace/config.go
POSTPONED - requires major refactoring asNew*Config
functions are exported and used in other packagesmetric/config.go
POSTPONED - requires major refactoringoteltest/config.go
exporters/otlp/options.go
exporters/otlp/protocoldriver.go
exporters/otlp/otlpgrpc/options.go
exporters/otlp/otlphttp/options.go
exporters/stdout/config.go
exporters/trace/jaeger/uploader.go
exporters/trace/zipkin/zipkin.go
"Codecov/patch" fails, because of the refactoring. The test coverage from the logical perspective remains the same.
Next PR(s)
Try tackling
trace/config.go
andmetric/config.go
.