Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Event type from the API to the SDK #1846

Merged
merged 6 commits into from
Apr 29, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 26, 2021

This type is not used in the API. It is used in the SDK and then through the processing pipelines. Move it to the package that originates its use.

Mostly resolves, but there are a few remaining questions for #1845
Part of #1380

This type is not used in the API. It is used in the SDK and then through
the processing pipelines. Move it to the package that originates its use.
@MrAlias MrAlias added pkg:API Related to an API package pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing release:1.0.0-rc.1 labels Apr 26, 2021
@MrAlias MrAlias added this to the RC1 milestone Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1846 (922b304) into main (e399d35) will increase coverage by 0.0%.
The diff coverage is 80.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1846   +/-   ##
=====================================
  Coverage   78.6%   78.6%           
=====================================
  Files        137     137           
  Lines       7305    7305           
=====================================
+ Hits        5746    5749    +3     
+ Misses      1315    1313    -2     
+ Partials     244     243    -1     
Impacted Files Coverage Δ
exporters/otlp/internal/transform/span.go 98.1% <ø> (ø)
exporters/trace/zipkin/model.go 99.1% <ø> (ø)
trace/trace.go 86.7% <ø> (ø)
sdk/trace/span.go 94.0% <75.0%> (ø)
exporters/otlp/internal/otlptest/data.go 88.0% <100.0%> (ø)
exporters/trace/jaeger/jaeger.go 92.8% <0.0%> (+0.5%) ⬆️
sdk/trace/batch_span_processor.go 87.1% <0.0%> (+1.5%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 8e55f10 into open-telemetry:main Apr 29, 2021
@MrAlias MrAlias deleted the mv-event branch April 29, 2021 17:29
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants