-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the Event type from the API to the SDK #1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is not used in the API. It is used in the SDK and then through the processing pipelines. Move it to the package that originates its use.
MrAlias
added
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
area:trace
Part of OpenTelemetry tracing
release:1.0.0-rc.1
labels
Apr 26, 2021
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
April 26, 2021 21:32
Codecov Report
@@ Coverage Diff @@
## main #1846 +/- ##
=====================================
Coverage 78.6% 78.6%
=====================================
Files 137 137
Lines 7305 7305
=====================================
+ Hits 5746 5749 +3
+ Misses 1315 1313 -2
+ Partials 244 243 -1
|
paivagustavo
approved these changes
Apr 28, 2021
Co-authored-by: Gustavo Silva Paiva <[email protected]>
Aneurysm9
approved these changes
Apr 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:trace
Part of OpenTelemetry tracing
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type is not used in the API. It is used in the SDK and then through the processing pipelines. Move it to the package that originates its use.
Mostly resolves, but there are a few remaining questions for #1845
Part of #1380