Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry policy for the OTLP/gRPC exporter #1832

Merged
merged 31 commits into from
Apr 29, 2021
Merged

Implement retry policy for the OTLP/gRPC exporter #1832

merged 31 commits into from
Apr 29, 2021

Conversation

paivagustavo
Copy link
Member

@paivagustavo paivagustavo commented Apr 21, 2021

Closes #1632

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1832 (117e25a) into main (ec75390) will increase coverage by 0.0%.
The diff coverage is 88.6%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1832   +/-   ##
=====================================
  Coverage   78.6%   78.7%           
=====================================
  Files        137     137           
  Lines       7305    7373   +68     
=====================================
+ Hits        5749    5808   +59     
- Misses      1313    1321    +8     
- Partials     243     244    +1     
Impacted Files Coverage Δ
exporters/otlp/otlpgrpc/connection.go 89.8% <85.0%> (-2.8%) ⬇️
exporters/otlp/internal/otlpconfig/options.go 91.0% <100.0%> (+0.2%) ⬆️
exporters/otlp/otlpgrpc/driver.go 92.4% <100.0%> (+0.4%) ⬆️
exporters/otlp/otlpgrpc/options.go 45.0% <100.0%> (+1.4%) ⬆️

@paivagustavo paivagustavo added pkg:exporter:otlp Related to the OTLP exporter package release:1.0.0-rc.1 labels Apr 21, 2021
exporters/otlp/retry.go Outdated Show resolved Hide resolved
exporters/otlp/retry.go Outdated Show resolved Hide resolved
exporters/otlp/retry.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/driver.go Outdated Show resolved Hide resolved
exporters/otlp/internal/otlpconfig/options.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/retry.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/retry.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/retry.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/retry.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/retry.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/connection.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/connection.go Outdated Show resolved Hide resolved
exporters/otlp/otlpgrpc/connection.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit f92a6d8 into open-telemetry:main Apr 29, 2021
@paivagustavo paivagustavo deleted the otlp_exporter_retry branch April 29, 2021 18:13
tigrannajaryan pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Apr 29, 2021
## Changes

The transient errors table in the `protocol/exporter.md` specify `Permission Denied` and `Unauthenticated` errors as retryable, but they're defined as _permanent_ error in the [otep-35](https://github.com/open-telemetry/oteps/blob/main/text/0035-opentelemetry-protocol.md#export-response) and in the `protocol/otlp.md` file.


### Related issues

This was found while implementing [retries in the go sdk](open-telemetry/opentelemetry-go#1832 (comment)).
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-proto that referenced this pull request Apr 20, 2023
## Changes

The transient errors table in the `protocol/exporter.md` specify `Permission Denied` and `Unauthenticated` errors as retryable, but they're defined as _permanent_ error in the [otep-35](https://github.com/open-telemetry/oteps/blob/main/text/0035-opentelemetry-protocol.md#export-response) and in the `protocol/otlp.md` file.

### Related issues

This was found while implementing [retries in the go sdk](open-telemetry/opentelemetry-go#1832 (comment)).
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec Conformance Review: OTLP Exporter Retries
6 participants