-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better attributes for ignored parents #461
Comments
I agree that the spec should discuss this. Does the spec describe |
Not outright, no. There is a confusing sentence in https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-tracing.md#span-creation (in the the second bullet point): API MAY also have an option for implicit parenting from the current context as a default behavior. So we introduce an option for "explicit non-parenting". ;) So not sure about the way forward with it - OTEP or a PR to spec? |
I think a PR to the spec would be appropriate. |
So, went through the spec and found a sentence in a paragraph after the bullet points: "Implementations MUST provide an option to create a So I think the |
Given the specification has deferred this decision we should back out the attributes that we are setting. This will ensure we are able to add them back in in a compatible manner after GA. |
We need to remove the links (so we do not have to introduce breaking changes), document how users can add their own links if they want them, and wait for the specification to come to a consensus on this (open-telemetry/opentelemetry-specification#1188). |
To ensure forwards compatibility, remove the unspecified links currently set on `NewRoot` spans. Resolves #461
To ensure forwards compatibility, remove the unspecified links currently set on `NewRoot` spans. Resolves #461
* Remove links on NewRoot spans To ensure forwards compatibility, remove the unspecified links currently set on `NewRoot` spans. Resolves #461 * Remove links from oteltest tracer to match
When #451 gets merged, we will get the
WithNewRoot()
option, that will ignore local and remote parents in the context and create a span with a new trace ID. The ignored parents will end up as links with a string attribute being"ignored-on-demand": "local"
or"ignored-on-demand": "remote"
for local and remote parents, respectively.This needs a better name and likely some piece of specification in SDK.
The text was updated successfully, but these errors were encountered: