Skip to content

Commit

Permalink
Disable DiesThenReconnects tests that are flaky
Browse files Browse the repository at this point in the history
  • Loading branch information
MadVikingGod authored and MrAlias committed Nov 12, 2021
1 parent a65d50a commit cdc6e99
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions exporters/otlp/otlpmetric/otlpmetricgrpc/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ func TestNewExporter_invokeStartThenStopManyTimes(t *testing.T) {
}

func TestNewExporter_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) {
// TODO: Fix this test #1527
t.Skip("This test is flaky and needs to be rewritten")
mc := runMockCollector(t)

reconnectionPeriod := 20 * time.Millisecond
Expand Down Expand Up @@ -491,6 +493,8 @@ func newThrottlingError(code codes.Code, duration time.Duration) error {
}

func TestNewExporter_collectorConnectionDiesThenReconnects(t *testing.T) {
// TODO: Fix this test #1527
t.Skip("This test is flaky and needs to be rewritten")
mc := runMockCollector(t)

reconnectionPeriod := 50 * time.Millisecond
Expand Down
4 changes: 4 additions & 0 deletions exporters/otlp/otlptrace/otlptracegrpc/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ func TestNew_invokeStartThenStopManyTimes(t *testing.T) {
}

func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) {
// TODO: Fix this test #1527
t.Skip("This test is flaky and needs to be rewritten")
mc := runMockCollector(t)

reconnectionPeriod := 20 * time.Millisecond
Expand Down Expand Up @@ -221,6 +223,8 @@ func TestNew_collectorConnectionDiesThenReconnectsWhenInRestMode(t *testing.T) {
}

func TestNew_collectorConnectionDiesThenReconnects(t *testing.T) {
// TODO: Fix this test #1527
t.Skip("This test is flaky and needs to be rewritten")
mc := runMockCollector(t)

reconnectionPeriod := 50 * time.Millisecond
Expand Down

0 comments on commit cdc6e99

Please sign in to comment.