Change ClientResponse to accept an *http.Response (#3617)

open-telemetry · Jan 26, 2023 · 604772d · 604772d
1 parent c0fb8de
commit 604772d
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/internal/tools/semconvkit/templates/httpconv/http.go.tmpl b/internal/tools/semconvkit/templates/httpconv/http.go.tmpl
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }
 

diff --git a/semconv/internal/v2/http.go b/semconv/internal/v2/http.go
@@ -53,7 +53,7 @@ type HTTPConv struct {
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func (c *HTTPConv) ClientResponse(resp http.Response) []attribute.KeyValue {
+func (c *HTTPConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
 	var n int
 	if resp.StatusCode > 0 {
 		n++

diff --git a/semconv/internal/v2/http_test.go b/semconv/internal/v2/http_test.go
@@ -47,7 +47,7 @@ var hc = &HTTPConv{
 
 func TestHTTPClientResponse(t *testing.T) {
 	const stat, n = 201, 397
-	resp := http.Response{
+	resp := &http.Response{
 		StatusCode:    stat,
 		ContentLength: n,
 	}

diff --git a/semconv/v1.13.0/httpconv/http.go b/semconv/v1.13.0/httpconv/http.go
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }
 

diff --git a/semconv/v1.14.0/httpconv/http.go b/semconv/v1.14.0/httpconv/http.go
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }
 

diff --git a/semconv/v1.15.0/httpconv/http.go b/semconv/v1.15.0/httpconv/http.go
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }
 

diff --git a/semconv/v1.16.0/httpconv/http.go b/semconv/v1.16.0/httpconv/http.go
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }
 

diff --git a/semconv/v1.17.0/httpconv/http.go b/semconv/v1.17.0/httpconv/http.go
@@ -68,7 +68,7 @@ var (
 // request contained in resp. For example:
 //
 //	append(ClientResponse(resp), ClientRequest(resp.Request)...)
-func ClientResponse(resp http.Response) []attribute.KeyValue {
+func ClientResponse(resp *http.Response) []attribute.KeyValue {
 	return hc.ClientResponse(resp)
 }