Make timestamps sequential in lastvalue agg check (#1579)

* Make timestamps sequential in lastvalue agg check * Set PR number in changelog * Fix location of sleep The lastvalue timestamp is set on update. Correct the location of the sleep to bridge the update of the two different aggregators.
open-telemetry · Feb 25, 2021 · 43886e5 · 43886e5
1 parent 37688ef
commit 43886e5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -48,6 +48,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 - The sequential timing check of timestamps in the stdout exporter are now setup explicitly to be sequential (#1571). (#1572)
 - Windows build of Jaeger tests now compiles with OS specific functions (#1576). (#1577)
+- The sequential timing check of timestamps of go.opentelemetry.io/otel/sdk/metric/aggregator/lastvalue are now setup explicitly to be sequential (#1578). (#1579)
 
 ## [0.17.0] - 2020-02-12
 

diff --git a/sdk/metric/aggregator/lastvalue/lastvalue_test.go b/sdk/metric/aggregator/lastvalue/lastvalue_test.go
@@ -101,6 +101,8 @@ func TestLastValueMerge(t *testing.T) {
 		first1.AddNumber(profile.NumberKind, first2)
 
 		aggregatortest.CheckedUpdate(t, agg1, first1, descriptor)
+		// Ensure these should not have the same timestamp.
+		time.Sleep(time.Nanosecond)
 		aggregatortest.CheckedUpdate(t, agg2, first2, descriptor)
 
 		require.NoError(t, agg1.SynchronizedMove(ckpt1, descriptor))