Skip to content

Commit

Permalink
Remove TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
MrAlias committed Jan 3, 2024
1 parent 9926cb7 commit 42d644b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions attribute/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,6 @@ func NewSetWithSortableFiltered(kvs []KeyValue, tmp *Sortable, filter Filter) (S
kvs = kvs[position:]

if filter != nil {
// TODO (MrAlias): there is a potential optimization here where the
// filtering and uniquing are all done in the same step. For example:
// https://github.com/open-telemetry/opentelemetry-go/blob/228cc878a0f5de19290e8b2035dc4d0019f2a249/attribute/set.go#L266-L300
if div := filteredToFront(kvs, filter); div != 0 {
return Set{equivalent: computeDistinct(kvs[div:])}, kvs[:div]
}
Expand Down

0 comments on commit 42d644b

Please sign in to comment.