Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build constraints for linux/non-linux systems #892

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Jun 19, 2024

This PR adds build constraints on files that contain Linux-specific logic or constants.
This allows running tests locally such as controller and manager on non-Linux systems.

@RonFed RonFed requested a review from a team June 19, 2024 12:52
@damemi
Copy link
Contributor

damemi commented Jun 20, 2024

@RonFed nit but looks like a couple of these new files are missing newlines at the end fyi

@edeNFed edeNFed merged commit 3acdf79 into open-telemetry:main Jun 30, 2024
18 checks passed
@RonFed RonFed deleted the non_linux_build branch June 30, 2024 06:25
@MrAlias MrAlias added this to the v0.14.0-alpha milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants