-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve eBPF context propagation stability #368
Merged
edeNFed
merged 72 commits into
open-telemetry:main
from
RonFed:ebpf_context_propagation
Oct 15, 2023
Merged
Improve eBPF context propagation stability #368
edeNFed
merged 72 commits into
open-telemetry:main
from
RonFed:ebpf_context_propagation
Oct 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
edeNFed
reviewed
Oct 14, 2023
Great work! The code looks much better now. I left a small question regarding |
edeNFed
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to improve the context propagation in the eBPF code by making it more stable across kernel versions and across instrumented libraries. Those fixes are the result of investigation of Keyval's customers running go auto instrumentation in production.
The changes can be divided into a few categories:
bpd_probe_write_user
helper function in order to modify user memory. The main challenge is to write to memory which we "allocate" since page faults won't get handled if they occur while the eBPF code attempts to write to such addresses. In order to reduce the page faults I added the following changes:allocate.go