Update HTTP span names to include method and route #143
Conversation
MikeGoldsmith
changed the title
Co-authored-by: Mike Goldsmith <[email protected]>
There was a problem hiding this comment.
This made me realize our span names contain high-cardinality paths which is not specification compliant:
HTTP spans MUST follow the overall guidelines for span names. HTTP server span names SHOULD be
{http.request.method} {http.route}if there is a (low-cardinality)http.routeavailable. HTTP server span names SHOULD be{http.method}if there is no (low-cardinality)http.routeavailable. HTTP client spans have nohttp.routeattribute since client-side instrumentation is not generally aware of the "route", and therefore HTTP client spans SHOULD use{http.method}. Instrumentation MUST NOT default to using URI path as span name, but MAY provide hooks to allow custom logic to override the default span name.
I think we will need a follow on issue/PR for this.
Co-authored-by: Tyler Yahn <[email protected]>
|
PR open-telemetry#143 updated these span names to include HTTP method per the spec.
PR open-telemetry#143 updated these span names to include HTTP method per the spec.
PR open-telemetry#143 updated these span names to include HTTP method per the spec.
PR open-telemetry#143 updated these span names to include HTTP method per the spec.
* wip: experiments with BATS * add a bats suite for gin instrumentation * ensure CI runner has bats installed * workflow YAML is not shell 🤦 * test: add assert_not_empty helper * more assertions for nethttp * more assertions for gorillamux spans currently show net/http, will need review for lib name * more assertions for gin * update http expectations after span name update PR #143 updated these span names to include HTTP method per the spec. * keep traces.json around + remove before verifying with e2e assertions + bring back redaction-jq as a function within the BATS utilities + assert no git difference with a BATS test * need to lookup gorillamux as net/http for now * update test for gorillamux spans now present --------- Co-authored-by: JamieDanielson <[email protected]>
Current semantic conventions state "HTTP server span names SHOULD be
{http.method} {http.route}".This PR adjusts http span names from
{http.route}to{http.method} {http.route}. Also updated are thetraces.jsonfiles to show the new name.