Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span attribute limit to auto/sdk #1315

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 25, 2024

Part of #1314

Adds parsing of span limits and implements the attribute count limit. The other limits will be added in follow-up PRs (see #1301)

Add functionality to `auto/sdk` so it can interpret configuration from
OTel defined environment variables for tracing limits.
@MrAlias MrAlias marked this pull request as ready for review November 25, 2024 16:12
@MrAlias MrAlias requested a review from a team as a code owner November 25, 2024 16:12
@MrAlias MrAlias mentioned this pull request Nov 25, 2024
4 tasks
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, but lgtm

sdk/limit.go Show resolved Hide resolved
sdk/limit_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the v0.19.0-alpha milestone Nov 26, 2024
Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@MrAlias MrAlias merged commit f75dc05 into open-telemetry:main Nov 27, 2024
27 checks passed
@MrAlias MrAlias deleted the span-attr-limit branch November 27, 2024 17:16
@MrAlias MrAlias mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants