Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to only generate what is needed #1213

Merged
merged 14 commits into from
Oct 31, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 24, 2024

Use depinfo files and make targets to ensure that generate is only run when needed.

Additionally, clean up the generate commands by using the environment variables for configuration.

@MrAlias MrAlias force-pushed the make-debinfo branch 11 times, most recently from dff8ebd to 5ce1d09 Compare October 24, 2024 17:50
Use depinfo files and make targets ensure that generate is only run when
needed.
@MrAlias MrAlias marked this pull request as ready for review October 24, 2024 18:17
@MrAlias MrAlias requested a review from a team as a code owner October 24, 2024 18:17
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@MrAlias MrAlias merged commit 7889fea into open-telemetry:main Oct 31, 2024
26 checks passed
@MrAlias MrAlias deleted the make-debinfo branch October 31, 2024 15:54
@MrAlias MrAlias added this to the v0.17.0-alpha milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants