Updated EKS Resource Detector to use Go Client for Kubernetes #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsvarma95
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
Aneurysm9
approved these changes
Jun 10, 2021
dashpole
approved these changes
Jun 14, 2021
MrAlias
approved these changes
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
+ Coverage 78.4% 78.9% +0.5%
=======================================
Files 62 62
Lines 2735 2711 -24
=======================================
- Hits 2146 2141 -5
+ Misses 455 437 -18
+ Partials 134 133 -1
|
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a change addressing #478
Changes
This is an enhancement feature. Instead of the EKS resource detector using the HTTP client directly to obtain the ConfigMap, the client-go Kubernetes client was used.