-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelhttp: Refactor Option interface #750
Merged
Aneurysm9
merged 6 commits into
open-telemetry:main
from
pellared:refactor-option-interface
Jul 2, 2021
Merged
otelhttp: Refactor Option interface #750
Aneurysm9
merged 6 commits into
open-telemetry:main
from
pellared:refactor-option-interface
Jul 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo and
XSAM
as code owners
April 15, 2021 15:07
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
=======================================
+ Coverage 78.4% 79.0% +0.6%
=======================================
Files 62 62
Lines 2737 2726 -11
=======================================
+ Hits 2146 2154 +8
+ Misses 456 440 -16
+ Partials 135 132 -3
|
@MadVikingGod Based on #746 (comment) I think you will like this PR 😉 |
I would like to see our configuration style guide updated before this is merged, but in general I'm in favor of this change. |
pellared
changed the title
Refactor Option interface
otelhttp: Refactor Option interface
Jul 1, 2021
@Aneurysm9 @MrAlias Can you take another look as the |
Aneurysm9
approved these changes
Jul 1, 2021
dashpole
approved these changes
Jul 2, 2021
garrettwegan
referenced
this pull request
in garrettwegan/opentelemetry-go-contrib
Jul 13, 2021
* Refactor Option interface * Refine Option doc comment
garrettwegan
referenced
this pull request
in garrettwegan/opentelemetry-go-contrib
Jul 22, 2021
* Refactor Option interface * Refine Option doc comment
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Add the UpDownSumObserver instrument * Precommit * Downcase error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adhere to https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#configuration
What
Unexport
Option.Apply
.