Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelhttp: Refactor Option interface #750

Merged
merged 6 commits into from
Jul 2, 2021
Merged

otelhttp: Refactor Option interface #750

merged 6 commits into from
Jul 2, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Apr 15, 2021

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #750 (811ed45) into main (01fdab7) will increase coverage by 0.6%.
The diff coverage is 80.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #750     +/-   ##
=======================================
+ Coverage   78.4%   79.0%   +0.6%     
=======================================
  Files         62      62             
  Lines       2737    2726     -11     
=======================================
+ Hits        2146    2154      +8     
+ Misses       456     440     -16     
+ Partials     135     132      -3     
Impacted Files Coverage Δ
detectors/gcp/gce.go 7.3% <0.0%> (ø)
detectors/gcp/gke.go 0.0% <0.0%> (ø)
exporters/metric/dogstatsd/internal/statsd/conn.go 59.2% <ø> (ø)
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 100.0% <ø> (ø)
instrumentation/host/host.go 73.1% <ø> (ø)
...umentation/net/http/httptrace/otelhttptrace/api.go 100.0% <ø> (ø)
...on/net/http/httptrace/otelhttptrace/clienttrace.go 76.2% <ø> (ø)
instrumentation/net/http/otelhttp/labeler.go 84.6% <ø> (ø)
detectors/aws/eks/detector.go 32.7% <33.3%> (+3.6%) ⬆️
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 87.0% <87.5%> (ø)
... and 21 more

@pellared
Copy link
Member Author

@MadVikingGod Based on #746 (comment) I think you will like this PR 😉

@MrAlias
Copy link
Contributor

MrAlias commented Apr 23, 2021

I would like to see our configuration style guide updated before this is merged, but in general I'm in favor of this change.

@pellared pellared changed the title Refactor Option interface otelhttp: Refactor Option interface Jul 1, 2021
@pellared
Copy link
Member Author

pellared commented Jul 1, 2021

@Aneurysm9 @MrAlias Can you take another look as the Option design is already documented?

@Aneurysm9 Aneurysm9 merged commit 6fd824a into open-telemetry:main Jul 2, 2021
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 13, 2021
* Refactor Option interface

* Refine Option doc comment
garrettwegan referenced this pull request in garrettwegan/opentelemetry-go-contrib Jul 22, 2021
* Refactor Option interface

* Refine Option doc comment
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* Add the UpDownSumObserver instrument

* Precommit

* Downcase error message
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants