Add WithCommandLoggingDisabled to otelmongo tracer #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-out of tracing the mongo statements
davidgwcurve
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
|
|
hey @dashpole @jmacd @MrAlias @evantorrie @XSAM, this is available for review now with all checks passed. I had issues with getting the CLA signed, EasyCLA was playing up. Please let me know if you have any comments. |
MrAlias
reviewed
Apr 6, 2021
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/config.go
Outdated
Show resolved
Hide resolved
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/config.go
Outdated
Show resolved
Hide resolved
…nfig.go Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
…nfig.go Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
reviewed
Apr 6, 2021
instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/config.go
Outdated
Show resolved
Hide resolved
|
thank you @MrAlias for the review! |
MrAlias
approved these changes
Apr 6, 2021
|
what is the process for getting this merged @MrAlias ? |
Another review from @open-telemetry/go-approvers or @open-telemetry/go-maintainers is required We are in the process of trying to get an RC released which has diminished our capacity to review things not directly related to that, but hopefully someone else will have some time soon. |
XSAM
approved these changes
Apr 8, 2021
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Prepare for releasing v0.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WithCommandLoggingDisabledto otelmongo tracer so the user can opt out of tracing the mongo statements. This is useful for applications which may log sensitive data but still want mongo tracing.Fixes Issue #712