otelhttp: handle nil base http transport #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjschnei001
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Aneurysm9
reviewed
Mar 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #713 +/- ##
=====================================
Coverage 78.4% 78.4%
=====================================
Files 60 60
Lines 2712 2714 +2
=====================================
+ Hits 2128 2130 +2
Misses 452 452
Partials 132 132
|
XSAM
approved these changes
Mar 30, 2021
MrAlias
approved these changes
Apr 6, 2021
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Update CODEOWNERS * Add Evan Torrie to CONTRIBUTING Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add a nil check in the
otelhttp.NewTransportfunction. I noticed this issue while I was using this library on a codebase where the transport was optionally nil. When calling Do on the wrapped client, it was throwing a nil pointer.Rather than put the onus on the user to make this check, it would be good to just transparently handle this case with a sane default (i.e. use the http.DefaultTransport).