Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add test coverage of version.go files #6443

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 12, 2024

@MrAlias MrAlias added this to the v1.34.0 milestone Dec 12, 2024
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a template for these? Not a blocker, though.

@MrAlias
Copy link
Contributor Author

MrAlias commented Dec 12, 2024

Should we use a template for these? Not a blocker, though.

Not sure it will save us much. I'm not opposed if you want to look into it after this is merged though.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.3%. Comparing base (3637e7f) to head (ef0c33c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6443     +/-   ##
=======================================
+ Coverage   68.0%   68.3%   +0.3%     
=======================================
  Files        200     200             
  Lines      16682   16682             
=======================================
+ Hits       11344   11404     +60     
+ Misses      4995    4933     -62     
- Partials     343     345      +2     

see 23 files with indirect coverage changes

@MrAlias MrAlias merged commit 323e373 into open-telemetry:main Dec 13, 2024
25 checks passed
@MrAlias MrAlias deleted the version-tests branch December 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants