Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run genjsonschema in CI #6353

Merged
merged 11 commits into from
Dec 3, 2024
Merged

Conversation

dmathieu
Copy link
Member

#6347 is updating the generated JSON schema, as it has changed with upgrades of go-jsonschema.
We update the binary semi automatically with dependabot. However, this means there could be unseen regressions or changes like this that we miss.

This runs the schema generation on CI, before checking for a clean repository, so we can keep the generated code up to date with the binary version.

This should fail until #6347 and #6349 are merged.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 20, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dmathieu dmathieu marked this pull request as ready for review November 21, 2024 08:23
@dmathieu dmathieu requested a review from a team as a code owner November 21, 2024 08:23
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wasn't sure where to add this when updating the types, but this is the obvious next step to make sure they don't go out-of-date.

@pellared
Copy link
Member

CC @codeboten

@dmathieu
Copy link
Member Author

@open-telemetry/go-approvers this needs a second review.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (0fc2c4c) to head (4587256).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6353   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        193     193           
  Lines      15660   15660           
=====================================
  Hits       10494   10494           
  Misses      4876    4876           
  Partials     290     290           

@dmathieu
Copy link
Member Author

dmathieu commented Dec 3, 2024

This has two reviews from approvers from the same employer.
However, it's also reviewed by the code owner of the config package. I am therefore going to merge it.

@dmathieu dmathieu merged commit 055b943 into open-telemetry:main Dec 3, 2024
25 checks passed
@dmathieu dmathieu deleted the ci-genjsonschema branch December 3, 2024 15:03
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants