-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for the prometheus bridge #5364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
reviewed
Apr 8, 2024
dashpole
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Apr 8, 2024
MrAlias
reviewed
Apr 8, 2024
dashpole
force-pushed
the
bridge_benchmarks
branch
from
April 8, 2024 15:12
68eeea3
to
85c02c1
Compare
MrAlias
approved these changes
Apr 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5364 +/- ##
=====================================
Coverage 61.8% 61.9%
=====================================
Files 186 186
Lines 11388 11388
=====================================
+ Hits 7049 7051 +2
+ Misses 4137 4136 -1
+ Partials 202 201 -1 |
dashpole
commented
Apr 8, 2024
dmathieu
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to get some rough numbers for how much overhead the prometheus bridge + OTLP exporter adds to pure Prometheus instrumentation, and also compare that with the Prometheus receiver vs OTLP receiver in the collector.
They aren't the best benchmarks (I used things like
top
anddocker stats
to measure), but the results broadly show what I expected, which is that is is much less expensive to do the translation client-side with the bridge, than server-side with the Prometheus Receiver.My sample code: prometheus/client_golang@main...dashpole:client_golang:benchmarking
cc @gouthamve @logicalhan