Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Add metrics support to NewServerHandler and NewClientHandler #4356

Merged
merged 10 commits into from
Nov 6, 2023

Merge branch 'main' into otelgrpc-statshandler-support-metric

da2f358
Select commit
Loading
Failed to load commit list.
Merged

otelgrpc: Add metrics support to NewServerHandler and NewClientHandler #4356

Merge branch 'main' into otelgrpc-statshandler-support-metric
da2f358
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 6, 2023 in 1s

80.8% (-0.2%) compared to 23181f7

View this Pull Request on Codecov

80.8% (-0.2%) compared to 23181f7

Details

Codecov Report

Merging #4356 (da2f358) into main (23181f7) will decrease coverage by 0.2%.
The diff coverage is 70.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4356     +/-   ##
=======================================
- Coverage   80.9%   80.8%   -0.2%     
=======================================
  Files        150     150             
  Lines      10313   10366     +53     
=======================================
+ Hits        8345    8376     +31     
- Misses      1827    1844     +17     
- Partials     141     146      +5
Files Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 86.2% <100.0%> (ø)
...ogle.golang.org/grpc/otelgrpc/metadata_supplier.go 51.1% <0.0%> (ø)
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 88.4% <76.5%> (-6.9%) ⬇️
...entation/google.golang.org/grpc/otelgrpc/config.go 69.6% <62.5%> (-5.0%) ⬇️
View more details on Codecov