Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove high cardanility metrics from otelhttp #4277

Merged
merged 9 commits into from
Sep 7, 2023

Address PR comments

3541453
Select commit
Loading
Failed to load commit list.
Merged

Remove high cardanility metrics from otelhttp #4277

Address PR comments
3541453
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 7, 2023 in 1s

82.6% of diff hit (target 79.4%)

View this Pull Request on Codecov

82.6% of diff hit (target 79.4%)

Annotations

Check warning on line 414 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/emicklei/go-restful/otelrestful/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gin-gonic/gin/otelgin/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/gorilla/mux/otelmux/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/github.com/labstack/echo/otelecho/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/gopkg.in/macaron.v1/otelmacaron/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/net/http/httptrace/otelhttptrace/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests

Check warning on line 414 in instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go#L410-L414 

Added lines #L410 - L414 were not covered by tests

Check warning on line 446 in instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/net/http/otelhttp/internal/semconvutil/httpconv.go#L445-L446 

Added lines #L445 - L446 were not covered by tests
View more details on Codecov