Add sem version to remaining instrumentation packages #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 19, 2020 09:39
Includes: - instrumentation/github.com/Shopify/sarama/otelsarama - instrumentation/github.com/emicklei/go-restful/otelrestful - instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo - instrumentation/net/http/otelhttp - instrumentation/net/http/httptrace/otelhttptrace
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
15 tasks
XSAM
approved these changes
Oct 27, 2020
jmacd
approved these changes
Oct 27, 2020
6 tasks
vchitai
pushed a commit
to vchitai/opentelemetry-go-contrib
that referenced
this pull request
Nov 13, 2020
…#412) * Add top-level sem version for remaining instrumentations Includes: - instrumentation/github.com/Shopify/sarama/otelsarama - instrumentation/github.com/emicklei/go-restful/otelrestful - instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo - instrumentation/net/http/otelhttp - instrumentation/net/http/httptrace/otelhttptrace * Update instrumentation README * Update CHANGELOG.md Co-authored-by: Tyler Yahn <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #214, every instrumentation should create its respective
Tracerand / orMeterwith a semantic version. This version should match the repository version, which is achieved by using theSemVerfunction incontrib.gofrom the top-level package.Most of the instrumentation packages already include semantic version, this PR collects and adjusts the remaining ones, which are:
It also adds this requirement to the
README.mdin instrumentation, as per request in the ticket description.Should be last piece to resolving #214.