[aws detector] Additional Attributes #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dackroyd
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
MrAlias
approved these changes
Oct 27, 2020
Adding extra host/cloud attributes from the semantic conventions that can be provided by AWS instance metadata: * `host.image.id` * `host.name` * `host.type` * `cloud.zone` Metadata (currently only `hostname`) failures will still allow the resource to be returned, along with a wrapped ErrPartialResource (per the Detector interface design)
dackroyd
force-pushed
the
add-missing-resource-attributes-to-aws-detection
branch
from
776adb4 to
d524be6
Compare
Aneurysm9
approved these changes
Oct 28, 2020
vchitai
pushed a commit
to vchitai/opentelemetry-go-contrib
that referenced
this pull request
Nov 13, 2020
Adding extra host/cloud attributes from the semantic conventions that can be provided by AWS instance metadata: * `host.image.id` * `host.name` * `host.type` * `cloud.zone` Metadata (currently only `hostname`) failures will still allow the resource to be returned, along with a wrapped ErrPartialResource (per the Detector interface design) Co-authored-by: Tyler Yahn <[email protected]>
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra host/cloud attributes from the semantic conventions that can be provided by AWS instance metadata:
host.image.idhost.namehost.typecloud.zoneMetadata (currently only
hostname) failures will still allow the resource to be returned, along with a wrapped ErrPartialResource (per the Detector interface design)Fixes #403