Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongo: use db.operation instead of resource.name #337

Merged
merged 3 commits into from
Sep 13, 2020
Merged

mongo: use db.operation instead of resource.name #337

merged 3 commits into from
Sep 13, 2020

Conversation

vmihailenco
Copy link
Contributor

spec says

db.operation The name of the operation being executed, e.g. the MongoDB command name such as findAndModify

vmihailenco
vmihailenco commented Sep 11, 2020
View reviewed changes
instrumentation/go.mongodb.org/mongo-driver/tags.go Outdated
TargetPortKey = label.Key("out.port")
HTTPMethodKey = label.Key("http.method")
HTTPCodeKey = label.Key("http.code")
HTTPURLKey = label.Key("http.url")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like HTTP* keys are unused and look out of place (and http.code should be http.status_code). Should I remove them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if they're unused there's no point keeping them around. There should be equivalents in the semconv package anyways.

MrAlias
MrAlias approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll wait to merge after the HTTP keys are removed.

@vmihailenco
Copy link
Contributor Author

@MrAlias done

@Aneurysm9 Aneurysm9 merged commit 9434278 into open-telemetry:master Sep 13, 2020
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@clsung @jmacd
move /global to /api/global (#356)
13cd2ac 
implement #337
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@XSAM XSAM Awaiting requested review from XSAM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
4 participants
@vmihailenco @Aneurysm9 @MrAlias @pellared