-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelaws] Add DynamoDB and SQS X-Ray specific attributes #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukestoward
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
October 22, 2022 08:26
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
+ Coverage 69.4% 69.6% +0.1%
=======================================
Files 146 147 +1
Lines 6752 6785 +33
=======================================
+ Hits 4692 4725 +33
Misses 1944 1944
Partials 116 116
|
Hey @Aneurysm9 / @dmathieu, would you mind taking a look at this PR when you have a few minutes please. Thanks 😃 |
dmathieu
reviewed
Oct 25, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes.go
Outdated
Show resolved
Hide resolved
Aneurysm9
approved these changes
Nov 2, 2022
MrAlias
approved these changes
Nov 2, 2022
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/attributes_test.go
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/sqsattributes_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS SDK v2 instrumentation library
otelaws
does not set SQS specific operational attributes. The goal here is to capture the SQS queue URL making it available to the AWS X-Ray exporter (in the collector) in order to provide more detailed telemetry data to X-Ray. Based on the PR comments, I've updated this PR to only include messaging attributes from the semantic conventions and not the AWS X-Ray bespoke attributes. This change will ensure the attributes are captured for SQS operations and made available to the exporters. Separately, we will need to update the collector exporter to extract the specific semantic convention attributes during the mapping between OTel and X-Ray.Below is an example trace from the AWS X-Ray console that demonstrates what is possible once DynamoDB table and SQS Queue URL information is captured and exported to X-Ray.
Before:
After: