[net/http] enhance otelhttp example to support metric #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
The metrics SDK is currently under heavy revamping to be moved out of beta (see the new_sdk branch). |
hanyuancheung
approved these changes
Aug 28, 2022
|
|
||
| } | ||
| global.SetMeterProvider(controller) | ||
|
|
There was a problem hiding this comment.
Suggested change
invalid blank line should be removed.
| log.Printf("Error shutting down meter provider: %v", err) | ||
| } | ||
| }() | ||
|
|
MrAlias
reviewed
Nov 3, 2022
fatsheep9146
force-pushed
the
otelhttp-example-enhancemant
branch
from
c5a5707 to
97c7520
Compare
MrAlias
reviewed
Nov 4, 2022
|
All comments are resolved @MrAlias |
dmathieu
reviewed
Nov 7, 2022
instrumentation/net/http/otelhttp/example/.vscode/settings.json
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
=====================================
Coverage 69.6% 69.6%
=====================================
Files 147 147
Lines 6785 6795 +10
=====================================
+ Hits 4725 4735 +10
Misses 1944 1944
Partials 116 116
|
Signed-off-by: Ziqi Zhao <[email protected]>
fatsheep9146
force-pushed
the
otelhttp-example-enhancemant
branch
from
9a734d7 to
dbf6e33
Compare
dmathieu
approved these changes
Nov 8, 2022
MrAlias
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziqi Zhao [email protected]
The current otelhttp example only contains the logic of traces, I added the support of metric.