Host metrics instrumentation #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey and
MrAlias
as code owners
MrAlias
reviewed
Aug 18, 2020
added 4 commits
August 18, 2020 11:30
MrAlias
approved these changes
Aug 20, 2020
|
It turns out that |
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instrumentation module implements metrics that the OTel Collector would also generate via its "hostmetrics" receiver. This covers only a minimum amount of information that is generally useful for monitoring, and leaves open questions about how to handle OS-specific metrics (esp. memory) and whether to encode per-CPU and per-NIC measurements for CPU and Network. See the new TODOs.
While working on this I filed several related specification questions:
open-telemetry/opentelemetry-specification#818
open-telemetry/opentelemetry-specification#819
This raises a very serious potential to share code with the OTel Collector's hostmetrics receiver, as that code is more thorough and handles OS-specific fields (with mock tests). On the other hand, factoring out that code module would be easier if we could migrate to using the real OTel-Go Metric SDK to generate these measurements. This is not out of the question, but too much work for this little PR, so I'll suggest that we start small with just a few metrics and evaluate this possibility later.