-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoprop package to provide configuration of propagators with useful defaults and envar support #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2258 +/- ##
=======================================
+ Coverage 73.7% 74.1% +0.3%
=======================================
Files 142 144 +2
Lines 6457 6549 +92
=======================================
+ Hits 4764 4856 +92
Misses 1550 1550
Partials 143 143
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
May 3, 2022 22:38
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I had a call with @MrAlias and we discussed 👆 The current approach with
|
pellared
approved these changes
May 4, 2022
dashpole
reviewed
May 24, 2022
Open
Aneurysm9
approved these changes
Jun 2, 2022
dashpole
approved these changes
Jun 2, 2022
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case
to replace
NewTextMapPropagator
act the same asNewCompositeTextMapPropagator
and override defaultsOTEL_PROPAGATORS
overrides defaults and argumentsRegisterTextMapPropagator
and then supported in the parsed propagator fromOTEL_PROPAGATORS
Resolve open-telemetry/opentelemetry-go#1265
Resolve open-telemetry/opentelemetry-go#2304
Related to open-telemetry/opentelemetry-go#1404