Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol configuration for grpc is incorrect #6337

Closed
codeboten opened this issue Nov 17, 2024 · 0 comments · Fixed by #6338
Closed

protocol configuration for grpc is incorrect #6337

codeboten opened this issue Nov 17, 2024 · 0 comments · Fixed by #6338
Assignees
@codeboten
Labels
area: config Related to config functionality bug Something isn't working
Milestone
v1.33.0

Comments

@codeboten
Copy link
Contributor

codeboten commented Nov 17, 2024 •
edited
Loading

Description

The otlp.protocol configuration for exporters currently checks if the protocol matches the string grpc/protobuf, it should be checking for grpc instead to match the specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options
@codeboten codeboten added area: config Related to config functionality bug Something isn't working labels Nov 17, 2024
@codeboten codeboten mentioned this issue Nov 17, 2024
Merged
dmathieu pushed a commit that referenced this issue Nov 18, 2024
@codeboten
config: fix otlp exporter protocol issue (#6338)
1dcb2c0 
The grpc protocol configuration for the OTLP exporter was incorrectly
using the string `grpc/protobuf` to validate the configuration. This
updates the validation to `grpc` which is spec compliant. Updated the
tests as well.

Fixes #6337

---------

Signed-off-by: Alex Boten <[email protected]>
@pellared pellared added this to the v1.33.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
area: config Related to config functionality bug Something isn't working
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging a pull request may close this issue.

config: fix otlp exporter protocol issue codeboten/opentelemetry-go-contrib
2 participants
@codeboten @pellared