Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go version in go.mod files #654

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 6, 2025

As of Go 1.21, versions must use the 1.N.P syntax.

These go.mod file versions are causing warnings and failures for our code scanning.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 6, 2025
@MrAlias MrAlias requested review from a team as code owners January 6, 2025 18:23
@MrAlias MrAlias requested a review from codeboten January 6, 2025 18:23
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.86%. Comparing base (3f22feb) to head (8ab67ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files          57       57           
  Lines        3381     3381           
=======================================
  Hits         1652     1652           
  Misses       1568     1568           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not go to the latest 1.22.10 version instead of .0?

@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 7, 2025

why not go to the latest 1.22.10 version instead of .0?

To support users still using 1.22.0.

@MrAlias MrAlias merged commit 44eed2f into open-telemetry:main Jan 7, 2025
13 of 14 checks passed
@MrAlias MrAlias deleted the go-mod-go-ver branch January 7, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants