Fix OpenTelemetry.Tracer.end_span return type spec

[RudolfMan]

Hi there!

Based on the specs of otel_span:end_span/0,1 this Tracer.end_span/0,1 is supposed to always return span context (:undefined is not an option for the return)

See here:

opentelemetry-erlang/apps/opentelemetry_api/src/otel_span.erl

Lines 291 to 306 in 0a38bd4

	-spec end_span(SpanCtx) -> SpanCtx when
	SpanCtx :: opentelemetry:span_ctx().
	end_span(SpanCtx=#span_ctx{span_sdk={Module, _}}) when ?is_recording(SpanCtx) ->
	_ = Module:end_span(SpanCtx, undefined),
	SpanCtx#span_ctx{is_recording=false};
	end_span(SpanCtx) ->
	SpanCtx.
	%% @doc Ends the given span context with the given timestamp.
	%%
	%% If `SpanCtx' is not recording, this function doesn't do anything.
	%% If `Timestamp' is `undefined', this is equivalent to {@link end_span/1}.
	%% Returns the updated span context.
	-spec end_span(SpanCtx, Timestamp) -> SpanCtx when
	SpanCtx :: opentelemetry:span_ctx(),
	Timestamp :: integer() | undefined.

[tsloughter]

I believe the otel_tracer.erl may be the incorrect one as SpanCtx could be undefined. Not positive yet, but that is my guess here.

[tsloughter]

@RudolfMan any update? I think you actually need to update otel_tracer to have undefined as a valid return of end_span.

[RudolfMan]

Just updated, @tsloughter!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.32%. Comparing base (0a969d1) to head (913e583).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   17.32%   17.32%           
=======================================
  Files          24       24           
  Lines         710      710           
=======================================
  Hits          123      123           
  Misses        587      587           

Flag	Coverage Δ
api	17.32% <ø> (ø)
elixir	17.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.